Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iperf3-based e2e test cases and make forced TCP stitching optional #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Aug 23, 2021

This PR adds several E2E test cases that use iperf3 to check that TCP stitching works for both UL and DL packets.
In order to make sure the problem is not masked by the current forced stitching behavior, it adds a proxy option:

set upf proxy force-stitching on|off

The status can be checked with show upf proxy:

vpp# show upf proxy 
MSS: 1250
FIFO Size: 64k
Max FIFO Size: 128m
Hi/Lo Watermark: 80 % / 50 %
Prealloc FIFOs: 0
Private Segment Count: 0
Private Segment Size: 512m
Force stitching: on

Copy link
Member

@RoadRunnr RoadRunnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the C part

`set upf proxy` force-stitching on|off controls the option.
`show upf proxy` displays "Force-stitching" status.
This includes an iperf3 upload test that fails with
"Fix TCP stitching in the UL direction" patch
(2531270) reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants